perf(parser): lex JSXText with memchr #2558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
CodSpeed Performance ReportMerging #2558 will improve performances by 8.03%Comparing Summary
Benchmarks breakdown
|
overlookmotel
force-pushed
the
03-01-perf_parser_faster_lexing_JSX_identifiers
branch
from
0852391 to
5857db3
Compare
overlookmotel
force-pushed
the
03-01-perf_parser_lex_JSXText_with_memchr
branch
2 times, most recently
from
1082bd3 to
ca4e27a
Compare
overlookmotel
changed the base branch from
03-01-perf_parser_faster_lexing_JSX_identifiers
to
02-29-refactor_parser_byte_search_macro_evaluate_to_matched_byte
This was referenced Mar 1, 2024
Boshen
force-pushed
the
02-29-refactor_parser_byte_search_macro_evaluate_to_matched_byte
branch
from
51e0e5c to
47e1a42
Compare
Base automatically changed from
02-29-refactor_parser_byte_search_macro_evaluate_to_matched_byte
to
main
March 1, 2024 13:28
|
@overlookmotel can you restack this, this PR is going off the rails 😅 |
overlookmotel
force-pushed
the
03-01-perf_parser_lex_JSXText_with_memchr
branch
from
ca4e27a to
e109e78
Compare
|
"We prefer smaller PRs". Well you asked for it! Restacked now. FYI The various other draft PRs branching off this are things I'd hoped would be simple to merge as a single stack, but they're not having the positive effects I'd hoped for on benchmarks, so want to fiddle with them a bit more. |
a-rustacean
pushed a commit
to a-rustacean/oxc
that referenced
this pull request
Mar 4, 2024
Lexing JSXText only requires searching for 2 possible characters (`<`
and `{`), so can use `memchr`.
a-rustacean
added a commit
to a-rustacean/oxc
that referenced
this pull request
Mar 4, 2024
This reverts commit 04a69de.
a-rustacean
added a commit
to a-rustacean/oxc
that referenced
this pull request
Mar 4, 2024
This reverts commit 04a69de.
1 task
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
Lexing JSXText only requires searching for 2 possible characters (`<`
and `{`), so can use `memchr`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lexing JSXText only requires searching for 2 possible characters (
<and{), so can usememchr.